1. texasnomad
   Member

   I'm tripping up on something basic, but two hours into this, I think it's time to step back and ask for help.

   Class level collections:
   [code]
   Dictionary<string, Summary> pairs = new Dictionary<string, Summary>();
   [/code]

   Assignment inside of Form1():
   [code]
   // The "EUR/USD key has already been added to the dictionary.
   pairs["EUR/USD"] = new Summary(0, 0, 0);
   pairs["EUR/USD"].IncrementTotal();
   [/code]

   Declaration of Summary structure:
   [code]
   struct Summary
   {
   private int winners, losers, total;

   public Summary(int tot,int win, int lose)
   {
   winners = win;
   losers = lose;
   total = tot;
   }

   public int Winners
   { get { return this.winners; } }

   public int IncrementWinner()
   { return this.winners++; }

   public int Losers
   { get { return losers; } }

   public int IncrementLoser()
   { return this.losers++; }

   public int Total
   { get { return total; } }

   public int IncrementTotal()
   { return total++; }
   }
   [/code]

   The output of total for EUR/USD should be 1 higher than the initialized value. It keeps coming out as the initialized value. What am I missing?

   Posted 2 years ago #

2. Bryman222
   Moderator

   I haven't tested it but... try this. Instead of
   

   public in IncrementTotal()
   { return total++; }

   Try this instead.
   

   public int IncrementTotal()
   { return ++total; }

   My thinking in this is that what you have is returning total and then incrementing total.
   With what I suggested it would increment total before returning it.
   Again, just a thought at first glance. I haven't tried it to make sure. Should be easy enough to try out. I hope that works.

   --Bryman222

   Posted 2 years ago #

3. texasnomad
   Member

   Thanks for the attempted fix. Unfortunately, the issue persists.

   Posted 2 years ago #

4. Bryman222
   Moderator

   Hmm. That's puzzling. You could always try incrementing the Total property and store that into a new variable.
   Then return that variable. I doubt that would be any different than what you've already tried but it can't hurt to try it.. I'd really have to see more code to see what exactly you're doing.

   --Bryman222

   Posted 2 years ago #

5. texasnomad
   Member

   Here's the stripped down version of the application that demonstrates the same issue.

   using System;
   using System.Collections.Generic;
   
   namespace test
   {
       class Program
       {
           static void Main(string[] args)
           {
               Dictionary<string, Summary> pairs = new Dictionary<string, Summary>();
   
               Summary item = new Summary(0,0,0);
               pairs.Add("EURUSD", item);
   
               pairs["EURUSD"].IncrementWinner();
   
               Console.WriteLine(String.Format("The current total is {0}", pairs["EURUSD"].Winners));
               Console.ReadLine();
           }
       }
       struct Summary
       {
           private int winners, losers, total;
   
           public Summary(int tot, int win, int lose)
           {
               winners = win;
               losers = lose;
               total = tot;
           }
   
           public int Winners
           { get { return this.winners; } }
   
           public int IncrementWinner()
           { return this.winners++; }
   
           public int Losers
           { get { return losers; } }
   
           public int IncrementLoser()
           { return this.losers++; }
   
           public int Total
           { get { return total; } }
   
           public int IncrementTotal()
           { return total++; }
       }
   }

   Posted 2 years ago #

6. texasnomad
   Member

   winners increments in IncrementWinner(), but the problem is that winners does not permanently change. When I modify the struct into a class, the incrementer works fine.

   Is this the difference between maintaining the values on the heap versus the stack?

   Posted 2 years ago #

RSS feed for this topic

Reply

You must log in to post.